This repository has been archived by the owner on May 17, 2024. It is now read-only.
3206 eventcard limit description lengths #3484
Merged
+125
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paaragon
requested review from
techtolentino,
eddybrando and
y4izus
as code owners
techtolentino
previously approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thank you for working on this @paaragon
Non-blocking comment:
my only question is if we need this margin-bottom here
I like the overall card layout spacing better without it:
Screen.Recording.2023-09-07.at.10.16.02.AM.mov
eddybrando
force-pushed
the
3206-eventcard-limit-description-lengths
branch
from
d2d8352 to
bf0595e
Compare
y4izus
force-pushed
the
3206-eventcard-limit-description-lengths
branch
from
bf0595e to
e0daebb
Compare
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
…ion to the top Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
eddybrando
force-pushed
the
3206-eventcard-limit-description-lengths
branch
from
e0daebb to
3bb7b8e
Compare
Good catch @techtolentino! Now we had too much spacing. I'm removing that extra spacing now. |
eddybrando
previously approved these changes
Jan 16, 2024
eddybrando
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #3206.
Descriptions in EventsCard have now a maximum length. If this max-length is exceeded, it is truncated and a "show more" is displayed.
If the "show more" is clicked, the entire length and a "show less" is displayed.
How to read this PR
Go to
/eventsand test the "show more"/"show less" functionality on the EventsCardsScreenshots
Show more:
Show less:
